apache / apache/jena

ShEx validation tests use exhaustive exclusion lists rather than manifest traits

Open
#1,593 0 comments 0 reactions 0 assignees View on GitHub
improvement
Dominant language
Java
Stars
1.4k
Forks
712
Avg merge
15h 41m
Merged PRs (30d)
53

Description

### Version

main

### What happened?

jena-shex validation tests include an exhaustive list of tests corresponding to unsupported features. This invites errors like the fact that [0_otherbnode](https://github.com/apache/jena/blob/c0535526e5be58a84b51c76f205c63db8671146f/jena-shex/src/test/files/spec/validation/manifest.ttl#L1326-L1337) is not excluded even though it uses the unsupported feature [ToldBNode](https://github.com/apache/jena/pull/1591/files#diff-721ef8bca5cdc10a7504b9836228b17c4d2cfbfb1408143c486cc509b59dd589R129). The accompanying PR #1591 enables filtering by trait and uses it for SemAct tests.

### Relevant output and stacktrace

_No response_

### Are you interested in making a pull request?

Yes

Contributor guide

Open the contributing guide

Research direction

Start with jena-shex/src/test/files/spec/validation/manifest.ttl and the validation tests that use its exclusion lists, then read PR #1591 for the existing trait-filtering approach. Done means the validation tests use manifest traits instead of exhaustive unsupported-feature lists, including correctly excluding 0_otherbnode for ToldBNode.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.