apache / apache/infrastructure-actions

Better diagnostics for un-allowlisted transitive actions

Open
#606 0 comments 0 reactions 0 assignees View on GitHub
enhancement gateway
Dominant language
Python
Stars
30
Forks
83
Avg merge
2d 18h
Merged PRs (30d)
79

Description

Since #279, the `dummy.yml` workflow is regularly invoked.

The goal of that was to detect the scenario where one of the listed actions is a composite action that depends on another action that has not been allowlisted yet (or is not allowlisted anymore). This is useful, but has a number of shortcomings:

* In case of new actions, this validation only occurs *after* the addition of an action with this problem has been merged. It would be great if we could perform this check as part of PR validation of new actions (and action updates). This is not a trivial matter of enabling the workflow on PRs, because it checks the listed actions against the allowlist actually configured in GitHub, which would not have the new action yet.
* If this workflow identifies a transitive non-allowlisted action, it's not always obvious to tell which action it's a transitive dependency of.
* Only the 'latest' version of each action is included in `dummy.yml`, so earlier still-allowlisted actions are not validated against their dependencies expiring

It would be really cool if we had our own script to check this, which could work for PRs and provide better diagnostics.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.