apache / apache/incubator-seata
Seata 2.3.0 Not support Eureka 2.x
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 26k
- Forks
- 8.8k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 4
Description
In Seata "EurekaRegistryServiceImpl" class
The constructor used to create eurekaclient is only available in Eureka 1.10.x
Code as follow :
eurekaClient = new DiscoveryClient(applicationInfoManager, new DefaultEurekaClientConfig());
Not Support the Eureka 2.0.3
The Constructor have been changed with 3 parameters as follow
DiscoveryClient(ApplicationInfoManager applicationInfoManager, EurekaClientConfig config, TransportClientFactories transportClientFactories)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the EurekaRegistryServiceImpl class and inspect the DiscoveryClient construction shown in the issue. Compare the current call with the three-parameter constructor required by Eureka 2.0.3, then verify that Eureka 2.x support works without losing the existing registry behavior. Done means Seata 2.3.0 can initialize its Eureka client with the newer API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100