apache / apache/incubator-seata-go

Refactor the implementation of the beforeImage and afterImage in the undo log

Open
#751 1 comment 0 reactions 1 assignee View on GitHub

@ForestLH is already working on this.

Since Feb 15, 2025.

Dominant language
Go
Stars
1.7k
Forks
356
Avg merge
7d 15h
Merged PRs (30d)
4

Description

What would you like to be added:

  1. Abstract beforeImage and afterImage, define them as interfaces, and implement their capabilities for MySQL.
  2. Replace the definitions in the executor with the new implementations mentioned above.
  3. Deprecate the implementation in the undo/builder package.

Why is this needed:

  1. Currently, there are two separate implementations for constructing undo log images, located in the exec package and the undo/builder package.
  2. The implementation in the undo/builder package is not being utilized.
  3. To better support different types of databases in the future, the implementation within the executor needs to be redefined and abstracted.
image image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.