apache / apache/incubator-pegasus

folly-rate-limiter in nfs may be block

Open
#846 0 comments 0 reactions 0 assignees View on GitHub
type/bug
Dominant language
C++
Stars
2.1k
Forks
328
PR merge metrics
No merged PRs in 30d

Description

## Bug Report

We found the [folly-rate-limiter](https://github.com/XiaoMi/rdsn/blob/v2.2.3/src/nfs/nfs_client_impl.cpp#L276) may be ineffective and block forever though it is inited as large value. however, it will recovery after reseting it via [remote-command](https://github.com/XiaoMi/rdsn/blob/v2.2.3/src/nfs/nfs_client_impl.cpp#L564)

We haven't found the reason and we are ready to add `switch` to control whether open the limiter.

Contributor guide

Open the contributing guide

Research direction

Start in src/nfs/nfs_client_impl.cpp at the folly-rate-limiter initialization around line 276 and the remote-command reset around line 564. Investigate why the limiter can block indefinitely despite a large initial value, reproduce the reported behavior, and verify that the limiter no longer remains stuck under those conditions.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.