apache / apache/incubator-pegasus
add NDEBUG macro when compile pegasus in release mode
Open
type/enhancement
- Dominant language
- C++
- Stars
- 2.1k
- Forks
- 328
- PR merge metrics
- No merged PRs in 30d
Description
now we use lots of assert() in our code, and do not add NDEBUG macro even when compile in release mode.
to improve:
* add NDEBUG macro when compile pegasus in release mode
* change necessary assert() to dassert()
* test and compare performance with NDEBUG and without NDEBUG
Contributor guide
Research direction
No files or tests are named. Start by locating the release-mode build configuration and the current assert()/dassert() definitions and usages; done means release builds define NDEBUG, necessary assertions use dassert(), and performance is compared with NDEBUG enabled and disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, databases, performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100