apache / apache/incubator-graphar

feat(c++): use nested namespace to distinguish different level reader/writer

Open
#619 1 comment 0 reactions 1 assignee Claimed by @acezen View on GitHub
enhancement
Dominant language
C++
Stars
373
Forks
93
Avg merge
7d 21h
Merged PRs (30d)
7

Description

### Describe the enhancement requested

Currently GraphAr c++ library use the class name to distinguish different level reader/writer like
`VertexPropertyChunkInfoReader` as info level vertex property reader and `VertexPropertyArrowChunkReader` as arrow vertex property reader. This makes the name too long and not concise.

Maybe we can use nested namespace to replace the naming like:
`VertexPropertyChunkInfoReader` -> `graphar::VertexChunkReader`
`VertexPropertyArrowChunkReader` -> `graphar::arrow::VertexChunkReader`
`AdjListChunkInfoReader` -> `graphar:AdjListChunkReader`
`AdjListArrowChunkReader` -> `graphar::arrow::AdjListChunkReader`
`AdjListOffsetChunkInfoReader` -> `graphar::OffsetChunkReader`
`AdjListPropertyChunkInfoReader` -> `graphar::EdgePropertyChunkReader`
`AdjListOffsetArrowChunkReader` -> `graphar::arrow::OffsetChunkReader`
`AdjListPropertyArrowChunkReader` -> `graphar::arrow::EdgePropertyChunkReader`

`VertexChunkInfoWriter` -> `graphar::VertexChunkWriter`
`VertexChunkArrowWriter` -> `graphar::arrow::VertexChunkWriter`
`EdgeChunkInfoWriter` -> `graphar::EdgeChunkWriter`
`EdgeChunkArrowWriter` -> `graphar::arrow::EdgeChunkWriter`

### Component(s)

C++

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.