apache / apache/ignite

SystemViewExporterSpi can not be properly configured

Open
#12,344 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
5.1k
Forks
1.9k
Avg merge
3d 2h
Merged PRs (30d)
46

Description

The IgniteConfiguration has a method setSystemViewExporterSpi to configure a SystemViewExporterSpi. My expectation is that when I set a no-op SPI there, no JMX beans for system views will be created.

Unfortunately, this is not the case. In the method GridSystemViewManager#addStandardExporters a new new JmxSystemViewExporterSpi() is **always added** to the already defined SPIs:
https://github.com/apache/ignite/blob/c9bbb2f97e851971482ec547b92f09a6a6592f29/modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/GridSystemViewManager.java#L247

This behaviour was introduced for the issue https://issues.apache.org/jira/browse/IGNITE-12921 - it was claimed that configuring a custom SystemViewExporterSpi leads to non-obvious behaviour to the user, while in my opinion the exact opposite is the case. The behaviour now is non-obvious.

Two questions then:
* Is there currently a way to disable system views?
* If not, could we please make the ignite configuration have an effect?

Contributor guide

Open the contributing guide

Research direction

Start with IgniteConfiguration#setSystemViewExporterSpi and GridSystemViewManager#addStandardExporters in modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/GridSystemViewManager.java. Trace how configured exporters are handled and verify that configuring a no-op SystemViewExporterSpi prevents JMX beans for system views from being created.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.