apache / apache/iggy

bug(connectors): meilisearch_sink URL scheme check is case-sensitive, silently connects to the wrong host

Open
#4,157 0 comments 0 reactions 1 assignee Claimed by @mattp5657 View on GitHub
connectors
Dominant language
Rust
Stars
4.9k
Forks
432
Avg merge
2d 10h
Merged PRs (30d)
173

Description

### Description

`meilisearch_sink::normalize_host` detects the URL scheme via `trimmed.starts_with("http://") || trimmed.starts_with("https://")`, which is case-sensitive. A config value like `HTTPS://realhost:9200` matches neither literal, falls through to the "no scheme" branch, and gets `http://` prepended, producing `http://HTTPS://realhost:9200`.

### Affected area / component

Connectors

### Proposed solution

Detect the scheme case-insensitively (e.g. `eq_ignore_ascii_case` on the split-off scheme) instead of a literal `starts_with` check.

### Alternatives considered

_No response_

### Contribution

- [x] I'm willing to submit a pull request to implement this feature

### Good first issue

- [ ] I think this could be a good first issue for a new contributor

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.