apache / apache/iceberg

investigate better API structure for RewriteTablePathUtil

Open
#16,983 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
9.2k
Forks
3.5k
Avg merge
2d 11h
Merged PRs (30d)
132

Description

Ok I don't think we need to do it in this PR but after looking at this, these APIs are getting pretty unfortunate, we're passing in 10 arguments now.

I think we'll want to introduce some builders and some structure like RewriteContext, and have structures which kick back things like a DeleteManifestRewriter.

I think what I'm asking here is more fundamental changes (and possibly an overhaul/elimination of this Util class) so like I said, definitely for something in the future.

_Originally posted by @amogh-jahagirdar in https://github.com/apache/iceberg/pull/15470#discussion_r3486737112_

Contributor guide

Open the contributing guide

Research direction

Start by reading RewriteTablePathUtil and the discussion in pull request #15470, focusing on how its ten arguments are used. Document a concrete API design involving builders, RewriteContext, and structures such as DeleteManifestRewriter, including whether the utility should be overhauled or eliminated.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.