apache / apache/iceberg-rust

ADLS: Support vended "adls.sas-token.xxx" prefixed tokens

Open
#1,442 2 comments 3 reactions 0 assignees View on GitHub
enhancement not-stale stale
Dominant language
Rust
Stars
1.4k
Forks
567
Avg merge
2d 2h
Merged PRs (30d)
93

Description

### Is your feature request related to a problem or challenge?

Currently the property handling in the new ADLS FileIO that was introduced in https://github.com/apache/iceberg-rust/pull/1368 (Thanks @DerGut !) isn't fully aligned with Java and as a consequence does not support the typical ADLS Vended Credentials format.

What we are currently missing is support for a config property key of the form `adls.sas-token..dfs.`. Instead, the SAS token must be provided as `adls.sas-token`.

Java handles this via a token prefix: https://github.com/apache/iceberg/blob/17f9a9fd28bbcb37745f13ebfcd57cd5a96e0a5d/azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java#L38

### Describe the solution you'd like

Support tokens of the form `adls.sas-token..dfs.` and map them to appropriate opendal config fields.

I can contribute this, but am currently a bit tight on time.

### Willingness to contribute

I can contribute to this feature independently

Contributor guide

Open the contributing guide

Research direction

Start by reading the new ADLS FileIO introduced in PR #1368 and Java's AzureProperties.java around line 38, where the token-prefix behavior is shown. Trace the existing property handling into the OpenDAL configuration, then verify that adls.sas-token..dfs. is mapped to the appropriate fields alongside the existing adls.sas-token form.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, rust
Domain
cloud
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.