apache / apache/iceberg-go

test: TestCreateAzureBucketManagedIdentityCredentialCalled is doing real IO

Open
#1,882 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
463
Forks
232
Avg merge
2d 11h
Merged PRs (30d)
121

Description

### Apache Iceberg version

None

### Please describe the bug 🐞

and doing a retry loop inside azure sdk (~100s). [An example run](https://github.com/apache/iceberg-go/actions/runs/32902971278/job/97980710396?pr=1679#step:7:7591).

It's an integration test disguised as unit. It should instead inject credentials factory or HTTP transport. At worst, a shorter context deadline.

cc @alessandro-nori

Contributor guide

Open the contributing guide

Research direction

Start with TestCreateAzureBucketManagedIdentityCredentialCalled and reproduce the real IO and Azure SDK retry loop described in the issue. Inspect how the test obtains credentials, then use an injected credentials factory or HTTP transport, or a shorter context deadline, so the test no longer performs real IO and completes without the ~100-second retry.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, go
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.