Remove the unused HudiPlugin class from hudi-trino

Open
#20,004 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
java

Research direction

Locate io.trino.plugin.hudi.HudiPlugin in hudi-trino's main sources and inspect the Hudi-side tests that install the connector. Check whether those tests require a plugin class and, if so, use the proposed test-only equivalent. Done means the main-source class is removed without breaking tests or the Trino duplicate-finder configuration.

Written by the indexing model from the issue text.

Description

Follow-up to #18780 (RFC-105 hudi-trino migration), raised in review of trinodb/trino#30682.

What

hudi-trino ships io.trino.plugin.hudi.HudiPlugin (checked in hudi-trino-1.2.1-rc2.jar), but no META-INF/services/io.trino.spi.Plugin descriptor, so Trino never loads it. The entry point Trino actually uses is the HudiPlugin in Trino's plugin/trino-hudi module, which wraps HudiConnectorFactory from hudi-trino.

Because both jars contain the same class, Trino's trino-hudi pom has to tell duplicate-finder to ignore io.trino.plugin.hudi.HudiPlugin.

Proposed fix

Remove HudiPlugin from hudi-trino's main sources. If Hudi-side tests need a plugin to install the connector, keep a test-only equivalent (for example TestingHudiPlugin).

Why here

Under RFC-105 the Trino-side HudiPlugin is the only entry point, and the class in hudi-trino can only be removed here.

Dominant language
Java
Stars
6.3k
Forks
2.5k
Avg merge
1d 23h
Merged PRs (30d)
111

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/hudi

All issues in apache/hudi

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.