Remove the unused HudiPlugin class from hudi-trino
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- java
- Domain
- data-engineering
Research direction
Locate io.trino.plugin.hudi.HudiPlugin in hudi-trino's main sources and inspect the Hudi-side tests that install the connector. Check whether those tests require a plugin class and, if so, use the proposed test-only equivalent. Done means the main-source class is removed without breaking tests or the Trino duplicate-finder configuration.
Written by the indexing model from the issue text.
Description
Follow-up to #18780 (RFC-105 hudi-trino migration), raised in review of trinodb/trino#30682.
What
hudi-trino ships io.trino.plugin.hudi.HudiPlugin (checked in hudi-trino-1.2.1-rc2.jar), but no META-INF/services/io.trino.spi.Plugin descriptor, so Trino never loads it. The entry point Trino actually uses is the HudiPlugin in Trino's plugin/trino-hudi module, which wraps HudiConnectorFactory from hudi-trino.
Because both jars contain the same class, Trino's trino-hudi pom has to tell duplicate-finder to ignore io.trino.plugin.hudi.HudiPlugin.
Proposed fix
Remove HudiPlugin from hudi-trino's main sources. If Hudi-side tests need a plugin to install the connector, keep a test-only equivalent (for example TestingHudiPlugin).
Why here
Under RFC-105 the Trino-side HudiPlugin is the only entry point, and the class in hudi-trino can only be removed here.
- Dominant language
- Java
- Stars
- 6.3k
- Forks
- 2.5k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 111
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/hudi
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
CompactionAdminClient.unscheduleCompactionFileId drops every other operation in the same partition Opentype:bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
area:ci priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
objectionary/hone-maven-plugin#1061 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
spring-projects/spring-modulith#1895 ·