apache / apache/hudi

Improve variable naming around time in incremental query logic

Open
#17,289 1 comment 0 reactions 1 assignee Assigned to @yihua View on GitHub
area:code-quality from-jira priority:critical type:devtask
Dominant language
Java
Stars
6.2k
Forks
2.5k
Avg merge
2d 8h
Merged PRs (30d)
111

Description

It can be confusing to use "Start" or "Time" without much context as we have the checkpoint to resume from and stop at for the incremental queries, and instant and completion time in the timeline.  So it would be good to do the following renaming and make the names consistent across the code base:
* "beginCompletionTime": checkpoint to resume from
* "endCompletionTime": checkpoint to stop at
* "instantTime"/"commitTime": for instant time or start time of an instant on the timeline
* "completionTime": completion time of an instant

Do not use "startTime", "endTime", etc that can cause confusion.

 

## JIRA info

- Link: https://issues.apache.org/jira/browse/HUDI-8373
- Type: Sub-task
- Parent: https://issues.apache.org/jira/browse/HUDI-9107
- Fix version(s):
- 1.1.0

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.