Optimize shouldIgnoreConfig check in HoodieWriterUtils
- Dominant language
- Java
- Stars
- 6.2k
- Forks
- 2.5k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 111
Description
[https://github.com/apache/hudi/pull/11943#discussion_r1809691906]
Every config key goes through shouldIgnoreConfig check. For config keys that do not require checks, we should just exclude them from "params" first.
{code:java}
params.foreach { case (key, value) =>
if (!shouldIgnoreConfig(key, value, params)) {
val existingValue = getStringFromTableConfigWithAlternatives(tableConfig, key)
if (null != existingValue && !resolver(existingValue, value)) {
diffConfigs.append(s"$key:\t$value\t${tableConfig.getString(key)}\n")
}
}
} {code}
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-8426
- Type: Improvement
- Fix version(s):
- 1.1.0
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.