apache / apache/hudi

Revisit setRecordMerger API in HoodieReaderContext

Open
#16,695 1 comment 0 reactions 1 assignee Assigned to @yihua View on GitHub
from-jira priority:high type:improvement
Dominant language
Java
Stars
6.2k
Forks
2.5k
Avg merge
2d 8h
Merged PRs (30d)
111

Description

[https://github.com/apache/hudi/pull/11943#discussion_r1805545250]

The HoodieReaderContext has the following API which takes `Option`.  By design, the merge implementation class should always be non-empty.  So we need to see if changing the argument type to `HoodieRecordMerger` incurs any error.
{code:java}
public void setRecordMerger(Option recordMerger) {
this.recordMerger = recordMerger;
}{code}

## JIRA info

- Link: https://issues.apache.org/jira/browse/HUDI-8417
- Type: Improvement
- Fix version(s):
- 1.1.0

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.