apache / apache/hudi

Add reader state class to remove state from the reader context

Open
#16,605 2 comments 0 reactions 1 assignee Assigned to @yihua View on GitHub
area:reader from-jira priority:critical type:improvement
Dominant language
Java
Stars
6.2k
Forks
2.5k
Avg merge
2d 8h
Merged PRs (30d)
111

Description

Reader context is getting cluttered with state. Create new class to contain all that so we can keep the reader context a bit more simple

## JIRA info

- Link: https://issues.apache.org/jira/browse/HUDI-8170
- Type: Improvement
- Epic: https://issues.apache.org/jira/browse/HUDI-6243
- Fix version(s):
- 1.1.0

---

## Comments

23/Oct/24 06:30;yihua;In HUDI-8203 (https://github.com/apache/hudi/pull/11943), record merger is made `Option` (see https://github.com/apache/hudi/pull/11943#discussion_r1805544464).  We should make it final so that there is no chance of hitting NPE or merge implementation class not set.;;;

---

23/Oct/24 06:52;yihua;Another improvement: we should get rid of the call `readerContext.setRecordMerger(readerContext.getRecordMerger(...))` and only have `setRecordMerger` for simplicity (see details in https://github.com/apache/hudi/pull/11943#discussion_r1805660051).;;;

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.