Refactor HoodieWriteConfig to make sure we have a uniform and better way to access config value
- Dominant language
- Java
- Stars
- 6.2k
- Forks
- 2.5k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 111
Description
I feel like this class is a hodgepodge and is ballooning. It does not demonstrate the benefits of configuration separation that a pluggable architecture should bring.
if we keep wrap config.getString(ConfigKey) with a getter method such as config.get{$ConfigKey}() in HoodieWriteConfig, basically we need to include almost every configKey in every config(such as HoodieClusteringConfig,HoodieHBaseIndexConfig,HoodieIndexConfig,HoodieStorageConfig and etc) to HoodieWriteConfig
for the consistent manner and clean code purpose, I think we should inline all the getter methods that have no logic
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-4964
- Type: Improvement
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by comparing HoodieWriteConfig with HoodieClusteringConfig, HoodieHBaseIndexConfig, HoodieIndexConfig, and HoodieStorageConfig, focusing on getter methods that only wrap config.getString(ConfigKey). Define the intended uniform configuration access pattern and confirm that the refactor preserves the pluggable configuration separation described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- data-engineering
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100