Make HoodieMetadataPayload#preCombine not return a new payload
Open
from-jira
priority:high
type:improvement
- Dominant language
- Java
- Stars
- 6.2k
- Forks
- 2.5k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 111
Description
This method is assuming semantic that `preCombine` operation is bound to pick one or the other object, and should not create a new one. But HoodieMetadataPayload#preCombine create new payload and return it.
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-4222
- Type: Improvement
Contributor guide
No contributing guide indexed for this repository
Research direction
Search the repository for HoodieMetadataPayload#preCombine and inspect the method and its callers to understand the expected selection semantics. Done means preCombine returns one of the existing payloads rather than constructing a new payload; check any nearby tests or relevant call sites for verification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- data-engineering
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100