Bring back spotless plugin

spotless plugin has been turned off as the eclipse style format it was referencing was removed due to compliance reasons. 

We use google style eclipse format with some changes

90c90

<

---

>

242c242

<

---

>

 

The eclipse style sheet was originally obtained from [https://github.com/google/styleguide] which CC -By 3.0 license which is not compatible for source distribution (See [https://www.apache.org/legal/resolved.html#cc-by]) 

 

We need to figure out a way to bring this back

 

 

## JIRA info

- Link: https://issues.apache.org/jira/browse/HUDI-304
- Type: Task
- Epic: https://issues.apache.org/jira/browse/HUDI-2261

---

## Comments

16/Oct/19 07:49;vbalaji;[~leesf] : FYI  As part of [https://github.com/apache/incubator-hudi/pull/953] spotcheck is disabled. ;;;

---

16/Oct/19 09:12;xleesf;[~vbalaji] got it.
PS: I notice that the avro(https://github.com/apache/avro/blob/master/lang/java/eclipse-java-formatter.xml) uses apache lisence. CC [~vinoth];;;

---

17/Oct/19 04:14;vinoth;lets wait for the release to go (hopefully it goes) and then we can resume ?;;;

---

17/Oct/19 04:47;xleesf;yeah, of casuse wait for the release.;;;

---

26/Nov/19 17:04;vbalaji;[~xleesf]: We can use avro's eclipse-java-formatter.xml that you mentioned as it has compatible license. We can copy this formatter and tune it to match the style we have been using so far.  spotless-plugin by itself is also apache license.

[~xleesf] : Let me know if you are planning to do it.

I can see the benefits of spotless and would like to resurrect it soon in hudi :)

 ;;;

---

26/Nov/19 18:34;vinoth;tagging this for next release;;;

---

12/Dec/19 01:35;xleesf;[~vbalaji] Sorry for lately response maybe for the missing of notification. Will do it. ;;;

---

23/May/20 22:06;shivnarayan;[~xleesf]: is there any progress on this. ;;;

---

24/May/20 15:18;xleesf;[~shivnarayan] sorry, I do have much time to focus on the PR recently and make it HELP-WANTED if anyone wants to work on issue.;;;

---

09/Jan/21 20:05;vinoth;[~xushiyan] FYI. Flink recently reformatted everything, with code style, spotless, IDE being in sync. might be worth understanding what they did and if we can directly reuse

cc [~xleesf] [~vinoyang] ;;;

---

16/Jan/21 10:04;xushiyan;[~vinoth] Thanks, I've checked out flink's changes and made a PR to show a sample diff. 

https://github.com/apache/hudi/pull/2426;;;

---

29/Jul/21 03:14;uditme;[~xushiyan] is this still being targeted for hudi 0.9.0 ? Else lets move it to 0.10.0.;;;

---

01/Sep/21 22:54;githubbot;vinothchandar commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-910861287

@xushiyan we should probably pick this back up sometime?

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org
;;;

---

01/Sep/21 22:55;githubbot;hudi-bot commented on pull request #2426:
URL: https://github.com/apache/hudi/pull/2426#issuecomment-910862643

## CI report:

* b7aa291685a1a350fff98607ebcdf0d19ce64f3f UNKNOWN


Bot commands
@hudi-bot supports the following commands:

- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org
;;;

Start by reviewing the Spotless-related build configuration and the sample diff in pull request #2426. Compare the Apache-licensed Avro formatter with the existing Google-style deviations, including the 120-character line and comment limits. Done means Spotless is restored with a compatible formatter and the project’s formatting checks work again.

Written by the indexing model from the issue text.