apache / apache/hudi

[SUPPORT] Should we support fail-fast when heartbeat has been expired?

Open
#12,522 2 comments 0 reactions 0 assignees View on GitHub
area:writer
Dominant language
Java
Stars
6.2k
Forks
2.5k
Avg merge
2d 8h
Merged PRs (30d)
111

Description

Consider the following case if the `heartbeatIntervalInMs = 60 * 1000` and `numTolerableHeartbeatMisses = 10`, so `maxAllowableHeartbeatIntervalInMs = 600 * 1000`
- 00:00,write application start
- 00:01, 1st heartbeat send success
- 00:02, The hdfs network is abnormal or other network causes, send heartbeat failed
- 00:03-00:10, send heartbeat failed everytimes
- 00:11, heartbeat is expired because `currentTime[00:11] - lastHeartbeatTime[00:01] >= maxAllowableHeartbeatIntervalInMs`, according to the code logic, `lastHeartbeatTime` will be never updated
- 10:00, write application has been running for 10h to execute all the logic
- 10:00, write application start to commit by `BaseHoodieWriteClient::commitStats`, but it find that heartbeat has been expired, so fail the application by throwing exception
image

So we spent 10 hours running an app that we knew at 00:11 was not going to be successful.
Should we support fail-fast to save some unnecessary resource consumption?

**_Tips before filing an issue_**

- Have you gone through our [FAQs](https://hudi.apache.org/learn/faq/)?

- Join the mailing list to engage in conversations and get faster support at dev-subscribe@hudi.apache.org.

- If you have triaged this as a bug, then file an [issue](https://issues.apache.org/jira/projects/HUDI/issues) directly.

**Describe the problem you faced**

A clear and concise description of the problem.

**To Reproduce**

Steps to reproduce the behavior:

1.
5.
6.
7.

**Expected behavior**

A clear and concise description of what you expected to happen.

**Environment Description**

* Hudi version :

* Spark version :

* Hive version :

* Hadoop version :

* Storage (HDFS/S3/GCS..) :

* Running on Docker? (yes/no) :

**Additional context**

Add any other context about the problem here.

**Stacktrace**

```Add the stacktrace of the error.```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with BaseHoodieWriteClient::commitStats and the heartbeat timing described in the issue, including heartbeatIntervalInMs and numTolerableHeartbeatMisses. Determine how an expired heartbeat should cause earlier termination and define completion around avoiding work that will later fail at commit.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
data-engineering
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.