apache / apache/hop

[Task]: Remove listeners that detect component changes

Open
#8,180 0 comments 0 reactions 0 assignees View on GitHub
awaiting triage Hop Gui P3
Dominant language
Java
Stars
1.5k
Forks
476
Avg merge
19h
Merged PRs (30d)
227

Description

### What needs to happen?

Now that changes are detected using snapshot (an excellent idea), we can remove the listeners that sometimes indicate that the pipeline or workflow has been modified simply by opening a component. (like `Clone row ` transfo or `Write to log` action) .

Deprecate lsMod in BaseTransformDialog
`
protected ModifyListener lsMod;
`
and remove all `widget.addModifyListener(lsMod);`

Also remove any `input.setChanged();` that are sometimes added to the listeners

### Issue Priority

Priority: 3

### Issue Component

Component: Hop Gui

Contributor guide

Open the contributing guide

Research direction

Start in BaseTransformDialog by locating the lsMod ModifyListener declaration and then search the GUI sources for widget.addModifyListener(lsMod) and input.setChanged(). Remove the obsolete listener wiring and related changed-state calls while preserving snapshot-based change detection. Done means opening components such as Clone row or Write to log no longer falsely marks the pipeline or workflow as modified.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.