[Bug]: Environment variables not all set using system env variable values
- Dominant language
- Java
- Stars
- 1.5k
- Forks
- 476
- Avg merge
- 18h 32m
- Merged PRs (30d)
- 216
Description
### Apache Hop version?
2.8.0
### Java version?
openjdk17.0.1
### Operating system
Windows
### What happened?
I have set some variables in the system props / env variables in windows, i have restarted the apache hop gui, then i run a simple pipeline to see the values of that variables, some of them like aws, do not have a value at all, the password encoder plugin has a different value than what is set in the system env variables, but the aes encoder key has the correct value set in the system env variables. seems like the encoder plugin is taken from hop-config.json ? since nothing is in hop-cofing related to AES. but yet again when i run the hop-gui.bat i see the logs:
Java identified as "C:\Work\openjdk-17.0.1_windows-x64_bin\jdk-17.0.1\bin\java"
HOP_OPTIONS=-Xmx2048m -DHOP_AUDIT_FOLDER=C:\Work\ApacheHopProjects\AuditFolder -DHOP_CONFIG_FOLDER=C:\dev\dt-generic-hop -DHOP_PASSWORD_ENCODER_PLUGIN=AES -DHOP_AES_ENCODER_KEY=LocalDummyKey -DHOP_PLATFORM_OS=Windows -DHOP_PLATFORM_RUNTIME=GUI -DHOP_AUTO_CREATE_CONFIG=Y
Command to start Hop will be:
"C:\Work\openjdk-17.0.1_windows-x64_bin\jdk-17.0.1\bin\java" -classpath lib\core\*;lib\beam\*;lib\swt\win64\* -Djava.library.path=lib\core;lib\beam -Xmx2048m -DHOP_AUDIT_FOLDER=C:\Work\ApacheHopProjects\AuditFolder -DHOP_CONFIG_FOLDER=C:\dev\dt-generic-hop -DHOP_PASSWORD_ENCODER_PLUGIN=AES -DHOP_AES_ENCODER_KEY=LocalDummyKey -DHOP_PLATFORM_OS=Windows -DHOP_PLATFORM_RUNTIME=GUI -DHOP_AUTO_CREATE_CONFIG=Y org.apache.hop.ui.hopgui.HopGui

seems like some variables are taken from env some are not.
### Issue Priority
Priority: 3
### Issue Component
Component: Hop Gui
Contributor guide
Research direction
Start with hop-gui.bat and the displayed startup command, then compare those values with hop-config.json and the variables observed in the simple pipeline. Trace how the Hop GUI resolves system environment values and Java properties, including the password encoder and AES key. Done means the affected variables consistently use the intended system values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100