apache / apache/hop

[Task]: Remove the need to call the PropsUi.setLook()

Open
#2,638 4 comments 0 reactions 0 assignees View on GitHub
API awaiting triage P3
Dominant language
Java
Stars
1.5k
Forks
476
Avg merge
18h 33m
Merged PRs (30d)
204

Description

### What needs to happen?

migration: https://issues.apache.org/jira/browse/HOP-3829

I'd like to remove the need to call the PropsUi.setLook() method when creating each widget.

I have a proposal for a new method PropsUi.setTheme() which is processes the whole widget tree. 

No need to use the setLook() method anymore in action and transform plugins, except when dynamically adding widgets during execution (tab In/out for webservice). 

### Issue Priority

Priority: 3

### Issue Component

Component: API

Contributor guide

Open the contributing guide

Research direction

Start with migration HOP-3829 and trace how PropsUi.setLook() is called while action and transform plugins create widgets. Evaluate the proposed PropsUi.setTheme() behavior across the whole widget tree, preserving setLook() only for dynamically added widgets such as the webservice tab In/out controls. Done means ordinary widget creation no longer requires setLook().

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.