apache / apache/hamilton

Config resolvers should mirror other node functions

Open
#589 0 comments 0 reactions 0 assignees View on GitHub
decorators refactor
Dominant language
Jupyter Notebook
Stars
2.6k
Forks
213
PR merge metrics
No merged PRs in 30d

Description

This is an issue to recount some thoughts:

1. config resolvers return a function, instead they should return a node. This is inconsistent and we lose metadata from config resolvers.
2. using fn.__name__ directly in various decorators is likely a leaky abstraction. We either need to use Node here for this metadata, or we should standardize attaching things to the function itself...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.