apache / apache/hamilton

Allow registry of data validators for arguments

Open
#571 1 comment 0 reactions 0 assignees View on GitHub
data quality decorators enhancement
Dominant language
Jupyter Notebook
Stars
2.6k
Forks
213
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**
Currently you have to use check_output.custom. But, it should be as simple as adding to this list: https://github.com/DAGWorks-Inc/hamilton/blob/b207db71a79c12413b75f981277d813a82f1c89d/hamilton/data_quality/default_validators.py#L399.

We should do the same thing we do for data adapters for data validators, and change the registry to allow it.

**Describe the solution you'd like**

```python
class MyCustomValidator(BaseDefaultDataValidator):
...

from hamilton.registry import register_validator
register_validator(MyCustomValidator)
```

**Additional context**
Add any other context or screenshots about the feature request here.

Contributor guide

Open the contributing guide

Research direction

Read hamilton/data_quality/default_validators.py around the linked validator list, then inspect hamilton.registry and the existing data-adapter registration path. Trace how a custom BaseDefaultDataValidator should become available through register_validator. Done means the proposed registration flow works and the validator can be used without check_output.custom.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.