apache / apache/hamilton

remove dependency on typing_inspect

Open
#472 1 comment 0 reactions 0 assignees View on GitHub
repo-hygiene
Dominant language
Jupyter Notebook
Stars
2.6k
Forks
213
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**
It is lightweight, but not heavily maintained. We should be able to remove the dependency as the python API stabilizes.

I think `typing`, included in the stdlib, has most of the stuff we need, especially >3.7 (8? 9?). Specifically `get_origin`

https://github.com/ilevkivskyi/typing_inspect

**Describe the solution you'd like**
We should see what we can use in the stdlib, TBD. We should contribute back anything to python typing module that we can't do.

**Describe alternatives you've considered**
- Supporting the typing_inspect module
- Forking/including it in Hamilton

**Additional context**
Just looking through the code

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.