apache / apache/gravitino

[Improvement] add gradle window script and update spotless check stage

Open
#7,801 0 comments 0 reactions 0 assignees View on GitHub
improvement
Dominant language
Java
Stars
3.2k
Forks
935
Avg merge
1d 16h
Merged PRs (30d)
298

Description

### What would you like to be improved?

Hi team, I find the project is missing `gradlew.bat` script, I suggest add this script for the use who dev on windows.

Another thing I noticed is we use `spotless` to format our code, but it will run before `compileJava` stage.
So when I change code and run unit test, I need run format command before test.
```
tasks.named("compileJava").configure {
dependsOn("spotlessCheck")
}
```
How about we
- change this format check after `test`
- add a CI to check code style
- give a `pre-commit` script, user can put it into git hook folder, then before each commit it will auto run `spotlessApply` command

### How should we improve?

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating the Gradle build configuration and current Spotless task wiring, then inspect how repository scripts and CI checks are organized. Review the requested gradlew.bat, post-test formatting check, CI style check, and pre-commit options with maintainers; the work is done only when the agreed subset is implemented and its relevant checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, ci-cd, developer-experience
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.