apache / apache/gravitino

[Improvement] support different Docker versions for integration tests

Open
#6,491 2 comments 0 reactions 1 assignee Claimed by @diqiu50 View on GitHub
improvement
Dominant language
Java
Stars
3.2k
Forks
935
Avg merge
1d 17h
Merged PRs (30d)
286

Description

### What would you like to be improved?

1. List what docker versions are required to run the integration tests.
2. Support Docker version < 20.10+ if possible. Our CI runs Docker version 19.03.15 that does not have `host-gateway` feature required in trino integration test - https://github.com/apache/gravitino/blob/e8d06f4c18bfc25a2865436f722e4199f108b61a/integration-test-common/docker-script/docker-compose.yaml#L95
3. Support Compose V1 if possible. Our CI runs Compose V1. `docker compose up -d` errored out in our CI pipeline.

For 3, I managed to bypass it by installing Compose V2 through
```
mkdir -p ~/.docker/cli-plugins/
curl -SL https://github.com/docker/compose/releases/latest/download/docker-compose-linux-x86_64 -o ~/.docker/cli-plugins/docker-compose
chmod +x ~/.docker/cli-plugins/docker-compose
```

For 2, it is harder since our CI user does not have sudo access. While I am working with our CI team to find a solution, is there any plan to have the integration tests compatible with older version Docker?

### How should we improve?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.