[Improvement] Improve GravitinoCatalogManager close method
- Dominant language
- Java
- Stars
- 3.2k
- Forks
- 935
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 315
Description
### What would you like to be improved?
GravitinoCatalogManager's close method mixes static and volatile variables in a nonstatic method and that may cause issues. Correctly updating a static field from a non-static method can be tricky to get right and could easily lead to bugs if there are multiple threads.
### How should we improve?
See if this can be improved to be more thread safe.
Contributor guide
Research direction
Start by locating GravitinoCatalogManager and reading its close method, focusing on how static and volatile variables are updated. Trace callers and any related concurrency tests or lifecycle code mentioned in the repository. Done means the close operation has clearly thread-safe state updates without changing its intended lifecycle behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100