apache / apache/grails-core

Support (+) on JOINED_FILTERS

Open
#15,869 0 comments 4 reactions 0 assignees View on GitHub
relates-to:spring-security type: improvement
Dominant language
Groovy
Stars
2.9k
Forks
975
Avg merge
1d 22h
Merged PRs (30d)
92

Description

It would be handy to also support (+) on JOINED_FILTERS, e.g. for BasicAuth on a url-pattern, otherwise you need to state the whole default filter chain, or need to add the new filter using SpringSecurityUtils.clientRegisterFilter.

(+) should allow to add to the start or tail of the list, depending on its position relatively to JOINED_FILTERS.

e.g.:

[pattern:'/api/**', filters: '+myFilter, JOINED_FILTERS, -securityContextPersistenceFilter, -exceptionTranslationFilter'],

In this example, a myFilter is added to the head of the list.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how JOINED_FILTERS and SpringSecurityUtils.clientRegisterFilter handle filter lists, using the example in the issue as the target behavior. Verify that a filter prefixed with (+) is placed at the head or tail according to its position relative to JOINED_FILTERS, while the existing removals still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.