apache / apache/grails-core

For SNAPSHOTs of grails-forge: updates to grails-bom still requires a new build and deploy to update versions in grails-versions.properties

Open
#14,858 0 comments 0 reactions 0 assignees View on GitHub
relates-to: grails-forge
Dominant language
Groovy
Stars
2.9k
Forks
975
Avg merge
1d 22h
Merged PRs (30d)
92

Description

**The following makes application generation from grails-forge fast and may only need to be updated in project build/deploy documentation versus changed in the way versions are pulled into grails-forge when it is generating an application.**

`grails-forge` now automatically pulls in `assetPipelineGradleVersion` from grails-bom when it generates a project's `build.gradle` : https://github.com/grails/grails-forge/blob/717ca46bb7b0f670b865a3ecc515c9af0577df5e/grails-forge-core/src/main/java/org/grails/forge/feature/assetPipeline/AssetPipeline.java#L70 so it no longer has to be updated there also. 😄

**gradle.properties**
`assetPipelineGradleVersion=5.0.6`

**build.gradle**
```
plugins {
id "com.bertramlabs.asset-pipeline" version "$assetPipelineGradleVersion"
}
```

but you have to build and redeploy grails-forge for the -SNAPSHOT version to update `grails-versions.properties` which is where it stores versions pulled from `grails-bom` at build time, not at runtime.

https://github.com/grails/grails-forge/blob/6c00aee7decdb6b4f78ce987b10775f3f6feb0cf/grails-forge-core/src/main/java/org/grails/forge/util/VersionInfo.java#L100-L107

https://github.com/grails/grails-forge/blob/6c00aee7decdb6b4f78ce987b10775f3f6feb0cf/buildSrc/src/main/groovy/org/grails/forge/internal/tasks/WriteGrailsVersionInfoTask.java#L56-L64

https://github.com/grails/grails-forge/actions/runs/13420318625

Contributor guide

Open the contributing guide

Research direction

Start by reading VersionInfo.java around lines 100-107 and WriteGrailsVersionInfoTask.java around lines 56-64, then review the linked AssetPipeline.java entry point and build/deploy workflow. Determine whether the intended resolution is documentation or a change to how grails-bom versions reach grails-versions.properties. Done means the chosen approach addresses SNAPSHOT version updates without ambiguity.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy
Domain
build-system, release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.