apache / apache/grails-core

Enable trimDirectiveWhitespaces JSP directive in GSPs

Open
#14,264 0 comments 3 reactions 0 assignees View on GitHub
relates-to: grails-gsp
Dominant language
Groovy
Stars
2.9k
Forks
975
Avg merge
1d 22h
Merged PRs (30d)
92

Description

I'm following up on grails/grails-core#4128 to enable trimDirectiveWhitespaces in GSPs. The issue was closed and redirected to this repository, but an issue was never created in grails-gsp.

The [trimDirectiveWhitespaces directive](https://docs.oracle.com/cd/E19316-01/819-3669/bnajm/index.html) is available at page-level for JSP pages:
```<%@page trimDirectiveWhitespaces="true"%>```

We have a rather large HTML page that's rendering 15MB of HTML, though it crunches down to 670KB with gzip. It seems there's a large volume of whitespace introduced by whitespace in GSP templates, so this setting would definitely be useful.

Contributor guide

Open the contributing guide

Research direction

Start by locating the GSP directive-processing entry point and existing tests for page-level directives; no implementation file or test is named in the issue. Compare the requested trimDirectiveWhitespaces behavior with the linked JSP directive documentation, and consider the work done when GSP output trims directive-introduced whitespace and the behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy
Domain
web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.