apache / apache/grails-core

Inject Micronaut Http client at integrationstests

Open
#11,368 3 comments 0 reactions 0 assignees View on GitHub
relates-to: micronaut
Dominant language
Groovy
Stars
2.9k
Forks
975
Avg merge
1d 22h
Merged PRs (30d)
92

Description

Thanks for reporting an issue for Grails framework, please review the task list below before submitting the
issue. Your issue report will be closed if the issue is incomplete and the below tasks not completed.

NOTE: If you are unsure about something and the issue is more of a question a better place to ask questions is on Stack Overflow (http://stackoverflow.com/tags/grails) or Slack (http://slack-signup.grails.org). DO NOT use the issue tracker to ask questions.

### Task List

- [x] Steps to reproduce provided
- [n/a] Stacktrace (if present) provided
- [n/a] Example that reproduces the problem uploaded to Github
- [x] Full description of the issue provided (see below)

### Steps to Reproduce
When doing automatic integration testing in Micronaut, I can inject the embedded httpServer without specifying host nor port. This is very convenient as the port is randomised by default in tests.

Here is an example Spock testcase from Micronaut, where I have a HelloController that returns "Hello World":
```
@Inject
@Client('/') // <-- no need to specify port nor host
RxHttpClient client

void "call app"() {
when:
String reply = client.toBlocking().retrieve('/hello')

then:
reply == 'Hello World'
}
```

With Micronaut HTTP client being introduced in Grails 4.0, it would be very nice if we could avoid having to specify the hostname and port for Micronaut HTTP client in Grails integrationtests as well.

Right now I am doing this to get the Micronaut HTTP client in my integrationtests in Grails:
```
@LocalServerPort
Integer localServerPort // random port in tests

BlockingHttpClient httpClient

def setup() {
httpClient = httpClient ?: HttpClient.create(new URL("http://localhost:${localServerPort}")).toBlocking()
}
```

It would be very nice if I could do like in Micronaut:
```
@Inject
@Client('/') // <-- no need to specify port nor host
RxHttpClient client
```
### Expected Behaviour
the http client should be injected without needing to specify port and host

### Actual Behaviour
the http client does not get injected

### Environment Information

- **Operating System**: Ubuntu 18.04
- **Grails Version:** 4.0.0
- **JDK Version:** 8u212
- **Container Version (If Applicable):** N/A

### Example Application

- N/A - it is a feature request

Contributor guide

Open the contributing guide

Research direction

Start by locating the Grails integration-test setup and the Micronaut @Inject/@Client wiring described in the issue. Check how the embedded server's random port is exposed, then verify that an HTTP client can be injected without specifying host or port in an integration test.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy
Domain
backend, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.