apache / apache/gluten

[VL] Remaining issues for typed imperative aggregate

Open
#4,763 2 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Scala
Stars
1.6k
Forks
657
Avg merge
2d 14h
Merged PRs (30d)
80

Description

### Description

* `collect_list`
* If all input values are null, vanilla Spark return an empty array, but Velox return null.
* `collect_set`
* Velox does not register the companion functions of `set_agg`.
* If all input values are null, vanilla Spark return an empty array, but Velox return null.
* If there are nulls in the input values(not all values are null), vanilla Spark ignore null input, but Velox not ignore null input.

Exclude UTs:
1. SPARK-31993: concat_ws in agg function with plenty of string/array types columns in GlutenStringFunctionsSuite
Reason: If all input values are null, `collect_list` in vanilla Spark return an empty array, but `array_agg` in Velox return null.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.