apache / apache/gluten

[CORE] Drop the now-constant ">= 3.4" test gates

Open
#12,992 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Scala
Stars
1.6k
Forks
657
Avg merge
2d 14h
Merged PRs (30d)
80

Description

`spark-3.4` is the lowest supported profile, so `testWithMinSparkVersion(name, "3.4")` is just `test(name)` with extra indirection. 57 call sites across 14 files, mostly in `ScalarFunctionsValidateSuite`, `DeltaSuite` and `JsonFunctionsValidateSuite`.

`testWithRangeSparkVersion` and `ignoreWithSpecifiedSparkVersion` in `GlutenQueryTest` have no callers either.

Gates on 3.5 / 4.0 / 4.1 are live and should stay. No behaviour change — the point is that every remaining version gate is then a real one.

Best done after #12981. Follow-up to #12807.

Contributor guide

Open the contributing guide

Research direction

Start with GlutenQueryTest and the named call sites in ScalarFunctionsValidateSuite, DeltaSuite, and JsonFunctionsValidateSuite; inspect the 57 uses across the 14 files. Confirm the 3.4 gate is redundant, remove the unused helper methods with no callers, and leave the 3.5, 4.0, and 4.1 gates intact. Coordinate with the work in #12981 first.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.