apache / apache/gluten

[Build] branch-1.5 build fail on macOS due to breaking change introduced by glog

Open
#11,763 1 comment 0 reactions 0 assignees View on GitHub
triage
Dominant language
Scala
Stars
1.6k
Forks
657
Avg merge
2d 14h
Merged PRs (30d)
80

Description

### Problem description

When I build branch-1.5 on macOS with the following command:

```
./dev/buildbundle-veloxbe.sh --spark_version=3.3 --run_setup_script=ON --build_arrow=ON
```

It fails with the following error:

```
was not included correctly. See the document in the comment of logging.h for detail.
```

The root cause is clear(https://github.com/facebookincubator/velox/pull/16165), and it is already solved by velox.

But if I manually apply the fix to the velox_ep under gluten directory, it would be overwritten automatically by the get_velox.sh build script, so I propose to add a new switch: `--skip_get_velox` to skip the get velox step, it will make it easier to handle this kind of build issues.

### System information

N/A

### CMake log

```bash

```

Contributor guide

Open the contributing guide

Research direction

Start with dev/buildbundle-veloxbe.sh and the get_velox.sh build step under the gluten directory. Trace how build options are parsed and how velox_ep is fetched, then verify that a --skip_get_velox option bypasses only that step and allows the macOS branch-1.5 build workflow to continue.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.