apache / apache/gluten

Use clang-tidy to check cpp files

Open
#11,027 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Scala
Stars
1.6k
Forks
657
Avg merge
2d 21h
Merged PRs (30d)
85

Description

### Description

Use clang-tidy to check cpp files to make code robot.
1. Install clang-tidy tool
Download the tool from: https://github.com/llvm/llvm-project/releases/download/llvmorg-18.1.8/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
3. Compile the code
bash dev/builddeps-veloxbe.sh
4. run clang-tidy check script
python3 cpp/run-clang-tidy.py --fix fix --build-dir cpp/build/ --project-root /app/incubator-gluten

### Gluten version

None

Contributor guide

Open the contributing guide

Research direction

Start with cpp/run-clang-tidy.py and the build produced by dev/builddeps-veloxbe.sh. Run the documented clang-tidy command against cpp/build/ and inspect which cpp files it checks and what integration is still needed. Done means the cpp files can be checked with clang-tidy as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
build-system, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.