apache / apache/gluten

Improve the implementation of InputIteratorTransformer

Open
#10,542 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Scala
Stars
1.6k
Forks
657
Avg merge
2d 21h
Merged PRs (30d)
85

Description

### Description

The current implementation of InputIteratorTransformer has an assert that the child must be ColumnarInputAdapter. We should do the assertion eagerly.

### Gluten version

main branch

Contributor guide

Open the contributing guide

Research direction

Start by locating the InputIteratorTransformer implementation and inspect where it currently asserts that its child is a ColumnarInputAdapter. Determine how to move that assertion to the eager validation point, then run the relevant existing tests to confirm the transformer rejects invalid children as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.