apache / apache/fluss

Release buffer redundantly in ServerHandler

Open
#1,044 1 comment 0 reactions 0 assignees View on GitHub
priority=critical
Dominant language
Java
Stars
2.1k
Forks
625
Avg merge
3d 14h
Merged PRs (30d)
97

Description

### Search before asking

- [x] I searched in the [issues](https://github.com/alibaba/fluss/issues) and found nothing similar.

### Fluss version

0.6.0 (latest release)

### Please describe the bug 🐞

Currenly, fluss release buffer in server places:
1. com.alibaba.fluss.rpc.netty.client.NettyClientHandler#channelRead
2. com.alibaba.fluss.rpc.netty.server.NettyServerHandler#sendResponse
3. com.alibaba.fluss.rpc.netty.server.RequestProcessor#run

There is no guarantee that the buffer of a request is only release once.

### Solution

_No response_

### Are you willing to submit a PR?

- [ ] I'm willing to submit a PR!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading NettyClientHandler#channelRead, NettyServerHandler#sendResponse, and RequestProcessor#run. Trace how a request buffer moves through these three release points and verify the ownership behavior with the relevant RPC tests. Done means a request buffer is released exactly once.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.