apache / apache/fesod

[Enhancement] Enhance Code Quality Checking in CI

Open
#423 6 comments 0 reactions 1 assignee Claimed by @alaahong View on GitHub
discussion welcome enhancement good first issue
Dominant language
Java
Stars
6.2k
Forks
532
Avg merge
1d 3h
Merged PRs (30d)
42

Description

### Search before asking

- [x] I searched in the [issues](https://github.com/fast-excel/fastexcel/issues) and found nothing similar.

### Motivation

As a developer,
I wanna involve code quality checking into current CI pipeline,
So create this issue for tracking.

### Solution

Plan to involve below stack one by one:
1. Fix all test failure in project level
[DONE] https://github.com/fast-excel/fastexcel/pull/390 https://github.com/fast-excel/fastexcel/pull/372 https://github.com/fast-excel/fastexcel/pull/371 https://github.com/fast-excel/fastexcel/pull/361 https://github.com/fast-excel/fastexcel/pull/360 https://github.com/fast-excel/fastexcel/pull/348 https://github.com/fast-excel/fastexcel/pull/341 https://github.com/fast-excel/fastexcel/pull/334 https://github.com/fast-excel/fastexcel/pull/315 https://github.com/fast-excel/fastexcel/pull/298 https://github.com/fast-excel/fastexcel/pull/297 https://github.com/fast-excel/fastexcel/pull/286 https://github.com/fast-excel/fastexcel/pull/285 https://github.com/fast-excel/fastexcel/pull/284 https://github.com/fast-excel/fastexcel/pull/283
2. Add Jacoco into maven test phase, which is used to generate the code coverage
[DONE] https://github.com/fast-excel/fastexcel/pull/422
3. Add Codecov into CI, which is used to track the project and commit coverage status
[TODO] As a healthy project, the coverage should keep moving
4. [Optional] Add Unit Test Results within PR CI
[DONE] GitHub Action to Publish Test Results, it's friendly for developer to mention the failure case
https://github.com/fast-excel/fastexcel/pull/424
5. [Optional] Integration with Sonar
[TODO] As Fastexcel is based on POI, we often meet several security warning and finding
6. [Optional] Nightly Build
[DONE] As full test will take hours in CI, current CI only perform the core test, so how about to schedule the full test in nightly build?
https://github.com/fast-excel/fastexcel/pull/437
7. Add CI Check for Markdown files as document integration
https://github.com/fast-excel/fastexcel/pull/497

### Alternatives

_No response_

### Anything else?

Please feel free to suggest on the specific solution and more actions.

### Are you willing to submit a PR?

- [x] I'm willing to submit a PR!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.