apache / apache/eventmesh

[Enhancement] Do some code optimization.[EventMeshCommon]

Open
#4,763 1 comment 0 reactions 0 assignees View on GitHub
enhancement Stale
Dominant language
Java
Stars
1.8k
Forks
658
Avg merge
11h 29m
Merged PRs (30d)
52

Description

### Search before asking

- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.

### Enhancement Request

As [comment](https://github.com/apache/eventmesh/issues/1013#issuecomment-1920798532):
I found that the EventMeshCommon class in the original TCP package was referenced by the classes of grpc, HTTP, and other modules. So should I placed this class under the Common module and corrected the reference? This also eliminates the coupling between the modules of the Java SDK.

Now reference:
![image](https://github.com/apache/eventmesh/assets/89067331/a2d98427-b7d6-4518-aaa7-956b100be9c6)

### Describe the solution you'd like

Move EventMesh class to common module, and check original references.

### Are you willing to submit PR?

- [X] Yes I am willing to submit a PR!

### Code of Conduct

- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) *

Contributor guide

Open the contributing guide

Research direction

Start by locating EventMeshCommon in the original TCP package and inspecting its references from the gRPC, HTTP, and other modules. Then inspect the Common module and determine the affected Java SDK references. Done means the class is in the Common module and all original references resolve without cross-module coupling.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.