apache / apache/eventmesh

[Enhancement] General code simplification

Open
#3,855 1 comment 0 reactions 0 assignees View on GitHub
enhancement Stale
Dominant language
Java
Stars
1.8k
Forks
658
Avg merge
11h 29m
Merged PRs (30d)
52

Description

### Search before asking

- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.

### Enhancement Request

org/apache/eventmesh/common/EventMeshThreadFactory.java, ThreadPoolFactory.java
org/apache/eventmesh/common/protocol/grpc/common/BatchMessageWrapper.java, SimpleMessageWrapper.java
org/apache/eventmesh/common/protocol/http/HttpCommand.java, HttpEventWrapper.java
org/apache/eventmesh/common/protocol/tcp/Package.java

---
Use lombok simplify class def.

Extract the same code logic.

Remove unnecessary modifier in ThreadPoolFactory.

Use `Maps.newHashMap` to simplify init a map.

### Describe the solution you'd like

Use lombok simplify class def.

Extract the same code logic.

Remove unnecessary modifier in ThreadPoolFactory.

Use `Maps.newHashMap` to simplify init a map.

### Are you willing to submit PR?

- [X] Yes I am willing to submit a PR!

Contributor guide

Open the contributing guide

Research direction

Review the listed classes under org/apache/eventmesh/common and its protocol/grpc, http, and tcp subpackages, starting with the repeated class and initialization patterns. Apply the requested Lombok simplification, shared-logic extraction, modifier removal, and map initialization changes across those files, then verify the project still builds and tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.