apache / apache/echarts

Breaking change from 5.2.0 to 5.2.1: AxisBaseOption.data no longer available

Open
#15,941 11 comments 1 reaction 0 assignees View on GitHub
en stale
Dominant language
TypeScript
Stars
67.3k
Forks
19.8k
Avg merge
11d 14h
Merged PRs (30d)
8

Description

### Version
5.2.1

### Steps to reproduce
1. Build a chart referring to the `AxisBaseOption.data` field, e.g. in `EChartsOption.xAxis`
2. Upgrade from echarts 5.2.0 to 5.2.1
3. TypeScript compiler fails because the `data` field does not exist

### What is expected?
A breaking change should not exist in a patch version upgrade.

### What is actually happening?
Code breaks when patch version is upgraded.

---
See the data field here in 5.2.0: https://github.com/apache/echarts/blob/41b7769648333d0a1da1101ebebfc9174d618863/src/coord/axisCommonTypes.ts#L100

In 5.2.1 it's been moved to a different type: https://github.com/apache/echarts/blob/1c70026ec4d0bc18ac91163da7d11ed59c401ed4/src/coord/axisCommonTypes.ts#L120

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.