apache / apache/dubbo

Can dubbo SslConfig support load config from a keystore file

Open
#9,932 0 comments 0 reactions 0 assignees View on GitHub
type/proposal
Dominant language
Java
Stars
41.6k
Forks
26.4k
Avg merge
15h 13m
Merged PRs (30d)
4

Description

- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have searched the [release notes](https://github.com/apache/dubbo/releases) of this repository and believe that this is not a duplicate.

## Describe the feature

In the dubbo version 2.7.16, dubbo fix the ssl file leak bug by close the stream after use it. But when we want to use keystore file in ssl mode, we find that, before 2.7.16, we load load a string from keystore file and then build a InputStream to set to SslConfig. But after version 2.7.16, in org.apache.dubbo.remoting.api.SslContext, dubbo close the stream after build the context, we can't find a way to set to SslConfig again.
And there are two points we concern:
1)、The ssl cert file, private-key file and ca file which store in a keystore file, can dubbo SslConfig support load config from one keystore file?
2)、Except the keystore file usually that we think is safe, we can also load the config from a remote store service, can dubbo provide a way to let us load ssl config from remote?

Contributor guide

Open the contributing guide

Research direction

Start with SslConfig and org.apache.dubbo.remoting.api.SslContext, then trace how SSL configuration streams are created and closed after the context is built. Clarify whether the intended scope covers keystore files, remote store services, or both; done should provide a defined way to load the requested SSL configuration sources without recreating the file-leak issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.