apache / apache/dubbo

Exception should be thrown when subscribing application addresses and 'check=true' is set.

Open
#9,665 0 comments 0 reactions 0 assignees View on GitHub
type/discussion
Dominant language
Java
Stars
41.6k
Forks
26.4k
Avg merge
15h 13m
Merged PRs (30d)
4

Description

Even if `check=true` is set, exceptions should not be thrown out on mapping absence caused by trying to do application address subscription instructed by the default `application first` policy.

```java
if (CollectionUtils.isEmpty(subscribedServices)) {
if (check) {
throw new IllegalStateException("Should has at least one way to know which services this interface belongs to, subscription url: " + url);
}
return;
}
```

Contributor guide

Open the contributing guide

Research direction

The issue provides a Java snippet but no file or test path. Locate the code containing the exact IllegalStateException message and trace how the default "application first" policy handles application address subscription when no mapping exists. Resolve the contradiction between the title and body before changing behavior, then identify or add coverage for check=true with an absent mapping.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend-api-design, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.