apache / apache/dubbo

org.apache.dubbo.registry.client.ServiceDiscoveryRegistry.shouldRegister是不是有bug?

Open
#9,583 6 comments 0 reactions 0 assignees View on GitHub
type/discussion
Dominant language
Java
Stars
41.6k
Forks
26.4k
Avg merge
15h 13m
Merged PRs (30d)
4

Description

* Dubbo version: 3.0.5
* Operating System version: all
* Java version: 1.8

代码:
String side = providerURL.getSide();
boolean should = PROVIDER_SIDE.equals(side); // Only register the Provider.
但是调用此函数时,URL是发送到registry注册的URL,side字段已经被移除。
这导致了所有provider都不能在ServiceDiscoveryRegistry注册,从而导致如下的日志不停刷
WARN :20220117.164918010:Dubbo-shared-scheduler-thread-1: [DUBBO] Refreshing of service instance started, but instance hasn't been registered yet., dubbo version: 3.0.5, current host: 10.178.118.12:ServiceInstanceMetadataUtils.java:278

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.