[CodeReview 3.0] Dubbo in spring
- Dominant language
- Java
- Stars
- 41.6k
- Forks
- 26.4k
- Avg merge
- 15h 13m
- Merged PRs (30d)
- 4
Description
### 1) DubboConfigConfigurationRegistrar duplicate with DubboComponentScanRegistrar.
DubboConfigConfigurationRegistrar only has one function call:
```java
public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
// initialize dubbo beans
DubboSpringInitializer.initialize(registry);
}
```
but DubboComponentScanRegistrar also has this function call:
```java
public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
// initialize dubbo beans
DubboSpringInitializer.initialize(registry);
Set packagesToScan = getPackagesToScan(importingClassMetadata);
registerServiceAnnotationPostProcessor(packagesToScan, registry);
}
```
Contributor guide
Assessment
This issue has not been assessed yet.