apache / apache/dubbo

[CodeReview 3.0] Dubbo in spring

Open
#8,633 2 comments 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
Java
Stars
41.6k
Forks
26.4k
Avg merge
15h 13m
Merged PRs (30d)
4

Description

### 1) DubboConfigConfigurationRegistrar duplicate with DubboComponentScanRegistrar.
DubboConfigConfigurationRegistrar only has one function call:
```java
public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
// initialize dubbo beans
DubboSpringInitializer.initialize(registry);
}
```
but DubboComponentScanRegistrar also has this function call:
```java
public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
// initialize dubbo beans
DubboSpringInitializer.initialize(registry);

Set packagesToScan = getPackagesToScan(importingClassMetadata);

registerServiceAnnotationPostProcessor(packagesToScan, registry);
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.