apache / apache/dubbo

some improvements on routing

Open
#4,824 1 comment 0 reactions 0 assignees View on GitHub
type/proposal
Dominant language
Java
Stars
41.6k
Forks
26.4k
Avg merge
15h 13m
Merged PRs (30d)
4

Description

- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.

### Environment

* Dubbo version: 2.7.3
* Operating System version: macOS10.12.6
* Java version: 1.8

动态配置规则中,http://dubbo.apache.org/zh-cn/docs/user/demos/config-rule.html
可以配置consumer的相关参数来改变相关的 调用参数,具体做法是通过获取远端的动态配置覆盖`org.apache.dubbo.registry.integration.RegistryDirectory#overrideDirectoryUrl`属性,并且在后续调用时进行get逐个参数,来达到实时获取最新的调用参数从而实现实时改变调用行为。

但在调用走路由的过程中,即`org.apache.dubbo.registry.integration.RegistryDirectory#doList`方法中,调用的是` invokers = routerChain.route(getConsumerUrl(), invocation);`,从传入的是consumerUrl,从而导致路由相关的参数比如tag无法传入 。
建议这里结合下consumerUrl和overrideDirectoryUrl,这样的话例如标签路由也可以通过动态配置进行传入,而无需用`setAttachment`硬编码 的方式传入 。

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.