apache / apache/dubbo

is it useful that the isRuntime method of Router.class?

Open
#4,753 7 comments 0 reactions 0 assignees View on GitHub
type/discussion
Dominant language
Java
Stars
41.6k
Forks
26.4k
Avg merge
15h 13m
Merged PRs (30d)
4

Description

- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.

### Environment

* Dubbo version: 2.7.2 and latest master
* Operating System version: Linux
* Java version: 1.8

### Steps to reproduce this issue

I implement the `Router.java` interface, and override the `isRuntime` method, its java doc say that it only used when the providers changed or the router rule changed, but I found that `route` method is called everytime when execute a rpc request

I search the source code, and con't found where it used.

And the `isForce` method is useless, too.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.